London | ITP-2026-Jan | Said Fayaz Sadat | sprint 2 | Form controls #1001
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
fayaz551
changed the title
This comment has been minimized.
This comment has been minimized.
fayaz551
changed the title
This comment has been minimized.
This comment has been minimized.
fayaz551
changed the title
fayaz551
added
the
Needs Review
takanocap
added
Reviewed
|
|
||
| <br><br> | ||
|
|
||
| <label for="colour">T‑shirt Colour:</label> |
There was a problem hiding this comment.
Well done for the good job.
are you able to find a way to validate the (dropdown menu) ?
is there a way to use "value" for the each option of the select element? Does this affect the required attribute? see https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/select
Additional research - (may not be required) see below:
can you use input with pattern for validation in this case too and datalist validation? see this page may be of help https://developer.mozilla.org/en-US/docs/Learn_web_development/Extensions/Forms/Form_validation
There was a problem hiding this comment.
I misunderstood it at first, i thought im not using get or post actions neither am i connected to server so i didnt thought of adding the value to options, my bad, fixed it now.
There was a problem hiding this comment.
The "value" is needed for the "required" attribute to work for the validation. if you test without the validation without the value it will fail
Form-Controls/index.html
Outdated
| id="name" | ||
| name="name" | ||
| required | ||
| pattern="[A-Za-z ]{2,}" |
There was a problem hiding this comment.
can you use minlength instead of the pattern ?
Form-Controls/index.html
Outdated
| id="email" | ||
| name="email" | ||
| required | ||
| placeholder="example@email.com"> |
There was a problem hiding this comment.
can we use minlength to validate the email too ?
There was a problem hiding this comment.
absolutely, used it for email as well. Thanks for the feed back
…d pattern attribute with minlength
fayaz551
added
Needs Review
takanocap
added
Complete
2 participants
You must title your PR like this:
Region | Cohort | FirstName LastName | Sprint | Assignment Title
For example,
London | 25-ITP-May | Carol Owen | Sprint 1 | Alarm Clock
Fill in the template below - remove any sections that don't apply.
Complete the self checklist - replace each empty box in the checklist [ ] with a [x].
Add the label "Needs Review" and you will get review.
Respond to volunteer reviews until the volunteer marks it as "Complete".
Learners, PR Template
Self checklist
Changelist
i have added the form to collect information of customer like his name and email address and then proceeded to make tags to get the custom order from the customer.
Questions
i dont have any questions at the moment.